Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release script to handle -rc #773

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

jacobweinstock
Copy link
Member

Description

Update release script to handle -rc

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #773 (2109be0) into main (8ccefc1) will not change coverage.
The diff coverage is n/a.

❗ Current head 2109be0 differs from pull request most recent head b97f63d. Consider uploading reports for the commit b97f63d to get more accurate results

@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   51.16%   51.16%           
=======================================
  Files          33       33           
  Lines        1456     1456           
=======================================
  Hits          745      745           
  Misses        665      665           
  Partials       46       46           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4
Copy link
Member

FWIW, I've not been using this script. I just create an annotated tag manually.

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jul 18, 2023
@mergify mergify bot merged commit 08ea799 into tinkerbell:main Jul 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants