Split e2e tests from unit tests: #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 26 26
Lines 1100 1100
=======================================
Hits 611 611
Misses 474 474
Partials 15 15 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This makes it clear that there are 2 different
types of tests. Also remove nix in CI for tests.
The update to the make build target is to improve
the output.
current:
❯ make build
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
\
-o ./bin/tink-server-linux-amd64 \
./cmd/tink-server
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
\
-o ./bin/tink-worker-linux-amd64 \
./cmd/tink-worker
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
\
-o ./bin/tink-controller-linux-amd64 \
./cmd/tink-controller
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
\
-o ./bin/virtual-worker-linux-amd64 \
./cmd/virtual-worker
new:
❯ make build
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o ./bin/tink-server-linux-amd64 ./cmd/tink-server
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o ./bin/tink-worker-linux-amd64 ./cmd/tink-worker
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o ./bin/tink-controller-linux-amd64 ./cmd/tink-controller
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o ./bin/virtual-worker-linux-amd64 ./cmd/virtual-worker
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
We're getting: "warning: -s is deprecated as it is always enabled" The buf.lock was updated after a make verify. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
chrisdoherty4
approved these changes
May 10, 2023
|
@Mergifyio queue |
🛑 The pull request has been removed from the queuePull request #725 has been dequeued due to failing checks or checks timeout. You can take a look at In case of a failure due to a flaky test, you should first retrigger the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it clear that there are 2 different types of tests. Also remove nix in CI for tests. The update to the make build target is to improve the output.
current:
❯ make build CGO_ENABLED=0 \ GOOS=linux \ GOARCH=amd64 \ go build \ \ -o ./bin/tink-server-linux-amd64 \ ./cmd/tink-server CGO_ENABLED=0 \ GOOS=linux \ GOARCH=amd64 \ go build \ \ -o ./bin/tink-worker-linux-amd64 \ ./cmd/tink-worker CGO_ENABLED=0 \ GOOS=linux \ GOARCH=amd64 \ go build \ \ -o ./bin/tink-controller-linux-amd64 \ ./cmd/tink-controller CGO_ENABLED=0 \ GOOS=linux \ GOARCH=amd64 \ go build \ \ -o ./bin/virtual-worker-linux-amd64 \ ./cmd/virtual-workernew:
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: