Add v1alpha2 API

[chrisdoherty4]

Design: https://github.com/tinkerbell/roadmap/blob/main/design/20230222_tinkerbell_crd_refactor.md

This PR adds the new v1alpha2 API. The APIs are configured as unserved meaning consumers won't be able to request the v1alpha2 version yet.

Webhooks will be added in a separate PR.

[chrisdoherty4]

Struggling to work out why List types keep getting generated.

[moadqassem]

Struggling to work out why List types keep getting generated.

Do you mean this here:
https://github.com/tinkerbell/tink/pull/673/files#diff-929a63a497434edd4d1e013bf858fffbdba787e6b05c032321c1f634faac9414

[chrisdoherty4]

@moadqassem Yes. I've never seen a dedicated list CRD generated. Normally the list type is part of the CRD definition. I'm guessing I have something funky with my annotations.

I generated a new project with kubebuilder and did a quick cross reference but couldn't see anything.

[moadqassem]

@moadqassem Yes. I've never seen a dedicated list CRD generated. Normally the list type is part of the CRD definition. I'm guessing I have something funky with my annotations.

I generated a new project with kubebuilder and did a quick cross reference but couldn't see anything.

Did you try adding +kubebuilder:object:generate=false to your Objects ?

For example:

// +kubebuilder:object:generate=false
// +kubebuilder:object:root=true
// +kubebuilder:storageversion

// HardwareList contains a list of Hardware.
type HardwareList struct {
	metav1.TypeMeta `json:",inline"`
	metav1.ListMeta `json:"metadata,omitempty"`
	Items           []Hardware `json:"items"`
}

[chrisdoherty4]

@moadqassem I'll give that a go, but that didn't exist in our v1alpha1 API and reflecting on other projects they don't seem to have it either (and they don't have list resources).

[moadqassem]

@moadqassem I'll give that a go, but that didn't exist in our v1alpha1 API and reflecting on other projects they don't seem to have it either (and they don't have list resources).

I agree, would check also the genclient version, maybe something changed.

[codecov]

Codecov Report

Merging #673 (616a9c5) into main (b9619ec) will decrease coverage by 1.04%.
The diff coverage is n/a.

❗ Current head 616a9c5 differs from pull request most recent head c6f4499. Consider uploading reports for the commit c6f4499 to get more accurate results

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   49.30%   48.26%   -1.04%     
==========================================
  Files          18       18              
  Lines         860      951      +91     
==========================================
+ Hits          424      459      +35     
- Misses        428      484      +56     
  Partials        8        8              

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[chrisdoherty4]

@moadqassem We have lift off 🚀 .

[jacobweinstock]

thanks @chrisdoherty4