Create tags for all services #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags were not being pushed to quay.io for services other than quay.io/tinkerbell/tink, this tags tink-controller, tink-worker, and tink-cli.
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 45.06% 44.84% -0.22%
==========================================
Files 62 62
Lines 3557 3532 -25
==========================================
- Hits 1603 1584 -19
+ Misses 1872 1866 -6
Partials 82 82
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jacobweinstock
added
kind/bug
chrisdoherty4
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tags were not being pushed to quay.io for services other than quay.io/tinkerbell/tink, this tags tink-controller, tink-worker, and tink-cli with tags as well.
Why is this needed
Fixes: #641
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: