Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of failed task #630

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

micahhausler
Copy link
Contributor

Signed-off-by: Micah Hausler mhausler@amazon.com

Description

Failed tasks did not properly update the workflow status, and the overall workflow status perpetually showed as STATE_RUNNING

Why is this needed

To properly report a failed workflow

Fixes: #

How Has This Been Tested?

Added unit tests

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@micahhausler micahhausler requested a review from mmlb June 15, 2022 15:23
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #630 (290fda8) into main (bd1c1c0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 290fda8 differs from pull request most recent head c8602de. Consider uploading reports for the commit c8602de to get more accurate results

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   44.52%   44.57%   +0.04%     
==========================================
  Files          61       61              
  Lines        3519     3520       +1     
==========================================
+ Hits         1567     1569       +2     
+ Misses       1870     1869       -1     
  Partials       82       82              
Impacted Files Coverage Δ
server/kubernetes_api_workflow.go 30.30% <100.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1c1c0...c8602de. Read the comment docs.

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jun 15, 2022
@mergify mergify bot merged commit 88798fa into tinkerbell:main Jun 15, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants