Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid interpolation in docker-compose: #627

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

jacobweinstock
Copy link
Member

Description

This allows make run to successfully run and bring up the docker-compose stack.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This allows `make run` to successfully run and bring
up the docker-compose stack.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock added the kind/bug Categorizes issue or PR as related to a bug. label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #627 (6620bfd) into main (0a800a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   44.52%   44.52%           
=======================================
  Files          61       61           
  Lines        3519     3519           
=======================================
  Hits         1567     1567           
  Misses       1870     1870           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a800a4...6620bfd. Read the comment docs.

@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Jun 14, 2022
@mergify mergify bot merged commit 9039877 into tinkerbell:main Jun 14, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants