Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified tink hardware crd example #621

Merged
merged 2 commits into from
May 10, 2022

Conversation

panktishah26
Copy link
Contributor

@panktishah26 panktishah26 commented May 10, 2022

Modified tink hardware crd example

Signed-off-by: panktishah26 shah.pankti2609@gmail.com

Description

Modified tink hardware crd example.

Why is this needed

I have updated the tink hardware yaml file example which will help customers to create a cluster using CAPT.

Fixes: #

How Has This Been Tested?

I have tested this functionality with CAPT changes related to kubified stack in this PR.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@panktishah26 panktishah26 changed the title Added hardware controller for tink-controller Modified tink hardware crd example May 10, 2022
@panktishah26 panktishah26 force-pushed the tink-controller-hardware branch 2 times, most recently from 942644b to 69acc42 Compare May 10, 2022 22:10
micahhausler
micahhausler previously approved these changes May 10, 2022
Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

… data

Signed-off-by: panktishah26 <shah.pankti2609@gmail.com>
Signed-off-by: panktishah26 <shah.pankti2609@gmail.com>
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #621 (c8da9e8) into main (00d3337) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          61       61           
  Lines        3509     3509           
=======================================
  Hits         1567     1567           
  Misses       1860     1860           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d3337...c8da9e8. Read the comment docs.

Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micahhausler micahhausler added the ready-to-merge Signal to Mergify to merge the PR. label May 10, 2022
@mergify mergify bot merged commit 7a8ca47 into tinkerbell:main May 10, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants