Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tink-cli: Add bash to container image #595

Merged
merged 1 commit into from
Mar 10, 2022
Merged

tink-cli: Add bash to container image #595

merged 1 commit into from
Mar 10, 2022

Commits on Mar 10, 2022

  1. tink-cli: Add bash to container image 

    I've recently been bitten by alpine/busybox's ash not properly implementing
`[[` as a builtin while doing a bunch of work on sandbox's scripts. Changing
over to POSIX sh is an option but not really worth it imo as almost everyone
assumes sh == bash already and bash is also nice for interactive use anyway.

Bash ends up adding ~2.2MB to the image which I don't think matters, tink-cli
isn't going to be used in production all that much and its still pretty small.

tink-cli-yes-bash                latest            3f59f8e81a34   10 seconds ago   30.4MB
tink-cli-no-bash                 latest            e521b3895111   23 seconds ago   28.2MB

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
    @mmlb
    mmlb committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    efc33b6 View commit details
    Browse the repository at this point in the history