Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of client/main.go #570

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

nshalman
Copy link
Member

@nshalman nshalman commented Dec 8, 2021

Description

shell.nix: include docker-compose for Makefile compatibility
client: purge unused NewFullClientFromGlobal function
client: factor out grpcCredentialFromCertEndpoint from two locations into function

Why is this needed

This removes unused code, and factors out duplicate code into a single function. The codebase is better than it was before.

How Has This Been Tested?

make images
make run-stack
cat focal.yaml | docker exec -i tink_tink-cli_1 tink template create
docker exec -i tink_tink-cli_1 tink template get
docker exec -i tink_tink-cli_1 tink template delete <uuid>

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Nahum Shalman <nshalman@equinix.com>
Signed-off-by: Nahum Shalman <nshalman@equinix.com>
…into function

Signed-off-by: Nahum Shalman <nshalman@equinix.com>
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #570 (3ceec2a) into main (b72ab0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72ab0b...3ceec2a. Read the comment docs.

@nshalman nshalman requested review from micahhausler and stephen-fox and removed request for micahhausler December 8, 2021 20:07
@nshalman nshalman added the ready-to-merge Signal to Mergify to merge the PR. label Dec 9, 2021
@mergify mergify bot merged commit 6e66633 into tinkerbell:main Dec 9, 2021
@nshalman nshalman deleted the cleanup-tls branch December 9, 2021 14:38
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants