Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the default retry-interval unit to seconds #548

Merged

Conversation

rgl
Copy link
Contributor

@rgl rgl commented Oct 8, 2021

without a unit it was using 3ns instead of 3s

Description

I've noticed the tink-worker retry-interval was set to 3ns instead of 3s:

image

Why is this needed

Its needed to match the documentation and because 3s is a saner value than 3ns.

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

without a unit it was using 3ns instead of 3s

Signed-off-by: Rui Lopes <rgl@ruilopes.com>
@rgl rgl force-pushed the rgl-set-default-retry-interval-unit-to-seconds branch from f9b9d01 to d3e53dd Compare October 8, 2021 18:21
Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha!

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #548 (f9b9d01) into main (5923ca9) will not change coverage.
The diff coverage is n/a.

❗ Current head f9b9d01 differs from pull request most recent head d3e53dd. Consider uploading reports for the commit d3e53dd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5923ca9...d3e53dd. Read the comment docs.

@mmlb mmlb added ready-to-merge Signal to Mergify to merge the PR. kind/bug Categorizes issue or PR as related to a bug. labels Oct 8, 2021
@mergify mergify bot merged commit e8019c9 into tinkerbell:main Oct 8, 2021
@rgl rgl deleted the rgl-set-default-retry-interval-unit-to-seconds branch October 9, 2021 17:54
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants