Tink Server: Add basic smoke test for gRPC server: #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
basic-grcp-server-smoke-test
branch
from
f069ba6
to
fe4d644
Compare
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 33.61% 34.36% +0.74%
==========================================
Files 44 44
Lines 3385 3384 -1
==========================================
+ Hits 1138 1163 +25
+ Misses 2150 2122 -28
- Partials 97 99 +2
Continue to review full report at Codecov.
|
This should catch some runtime errors for the gRPC server. There aren't any runtime tests or checks yet in the codebase so this is just something to get us started. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
basic-grcp-server-smoke-test
branch
from
439daa8
to
848badd
Compare
tstromberg
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should catch some runtime errors for the gRPC server.
For example, the one seen in this issue #536
There aren't any runtime tests or checks yet in the codebase so this is just an initial start.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: