Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ineffective assignment in db/mock/template.go #511

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Jun 24, 2021

Description

While updating and rebasing #266, I noticed that golangci-lint was finding a new issue in our db mocking library. This PR addresses that issue

How Has This Been Tested?

I verified tests continued to work after updating the receiver type of the methods that modified the mock db variable.

How are existing users impacted? What migration steps/scripts do we need?

This change only impacts tests and no migrations are needed.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #511 (fbe7262) into master (7f829f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files          44       44           
  Lines        3137     3137           
=======================================
  Hits         1026     1026           
  Misses       2019     2019           
  Partials       92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f829f5...fbe7262. Read the comment docs.

@jacobweinstock jacobweinstock merged commit ab6a1cc into tinkerbell:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants