upgrade ptypes.TimestampProto to timestamppb.New #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arcolife <archit.py@gmail.com>
|
Thank you for this Pr and welcome to the community! |
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 32.70% 32.70%
=======================================
Files 44 44
Lines 3137 3137
=======================================
Hits 1026 1026
Misses 2019 2019
Partials 92 92
Continue to review full report at Codecov.
|
markjacksonfishing
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: arcolife archit.py@gmail.com
Description
upgrade
ptypes.TimestampProtototimestamppb.NewWhy is this needed
We're seeing deprecation notices in PRs.
How has this been tested