Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package jsonpb to protojson. #491

Merged

Conversation

rahulgrover99
Copy link
Contributor

Signed-off-by: Rahul Grover rahulgrover99@gmail.com

Description

Upgrades package github.com/golang/protobuf/jsonpb to google.golang.org/protobuf/encoding/protojson

Why is this needed

package github.com/golang/protobuf/jsonpb is deprecated.

Fixes: Staticcheck error. SA1019

Signed-off-by: Rahul Grover <rahulgrover99@gmail.com>
@markjacksonfishing
Copy link
Contributor

Thank you for this pr and welcome to the community!

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #491 (b5e2496) into master (8ea8a0e) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b5e2496 differs from pull request most recent head e1de0c7. Consider uploading reports for the commit e1de0c7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files          44       44           
  Lines        3137     3137           
=======================================
  Hits         1026     1026           
  Misses       2019     2019           
  Partials       92       92           
Impacted Files Coverage Δ
http-server/http_handlers.go 6.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea8a0e...e1de0c7. Read the comment docs.

@gauravgahlot
Copy link
Contributor

@rahulgrover99 Could you please update the branch and fix the CI issues?

@rahulgrover99
Copy link
Contributor Author

@gauravgahlot I was going through the checks that failed. It looks like the lint check failed because of the use of deprecated packages in db/template.go. Will it be a good idea to add nolint:staticcheck to those imports?
Also, another fail is because of no test coverage of the changes I made. Could you help me out with that as well? I am not sure what tests might help cover these changes.

@tstromberg
Copy link
Contributor

Thank you for your PR!

@tstromberg tstromberg merged commit 04b1e9e into tinkerbell:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants