Remove vagrant test #474
Merged
Remove vagrant test #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deploy directory is out of sync from sandbox and even if I have left this test here when I wrote sandbox with hope of using it to assert that tink repository work as the "Vagrant Setup guide" now it fails. Sandbox still has it and it runs successfully because it is maintained as the project itself (if sandbox does not work the test fails, but it is not the case for this repo) Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
gianarb
force-pushed
the
chore/vagrant-test
branch
from
a496de7
to
ac451df
Compare
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 32.32% 32.32%
=======================================
Files 50 50
Lines 3276 3276
=======================================
Hits 1059 1059
Misses 2123 2123
Partials 94 94 Continue to review full report at Codecov.
|
|
As a consequence, we won't catch e2e issues until somebody notices or until sandbox will run a new version of tink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deploy directory is out of sync from sandbox and even if I have left
this test here when I wrote sandbox with hope of using it to
assert that tink repository work as the "Vagrant Setup guide" now it
fails. Sandbox still has it and it runs successfully because it is
maintained as the project itself (if sandbox does not work the test
fails, but it is not the case for this repo)
Signed-off-by: Gianluca Arbezzano gianarb92@gmail.com