Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change package repository and fix build on mac" #462

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Mar 15, 2021

Reverts #459

Not sure why it got merged even if CI/CD is broken @markyjackson-taulia you should no merge that kind of issues and more in general you should leave Mergify doing the actual merge (excluding when a github action workflow changes because it does not merge those PRs)

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #462 (2ea510d) into master (0b11911) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files          47       47           
  Lines        2892     2892           
=======================================
  Hits         1036     1036           
  Misses       1763     1763           
  Partials       93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b11911...0a7c538. Read the comment docs.

@splaspood splaspood self-requested a review March 15, 2021 14:06
@mergify mergify bot merged commit 1b178da into master Mar 15, 2021
@mergify mergify bot deleted the revert-459-chore/bump-nix branch March 15, 2021 14:06
@mmlb
Copy link
Contributor

mmlb commented Mar 15, 2021

@gianarb looks like marky only approved but mergify merged it. Looks like CI didn't block the merge.
image

@gianarb
Copy link
Contributor Author

gianarb commented Mar 15, 2021

It looks like I can't read! Sorry @markyjackson-taulia !! And thanks @mmlb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants