db tests for hardware create events #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravgahlot
force-pushed
the
events-tests
branch
from
de6099d
to
8f0ea69
Compare
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 20.82% 21.24% +0.41%
==========================================
Files 24 24
Lines 2170 2170
==========================================
+ Hits 452 461 +9
+ Misses 1678 1667 -11
- Partials 40 42 +2
Continue to review full report at Codecov.
|
|
This is amazing @gauravgahlot !! Thank you for doing that! Do you mind adding another test that similarly to how we do for the template creates 10 hardware asynchronously?! I am very curious to see what happens under "load" :) |
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
gauravgahlot
force-pushed
the
events-tests
branch
from
8f0ea69
to
97fb342
Compare
|
In order to make CI happy here you have to format JSON with prettier. You can run this command: Thanks |
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
gauravgahlot
force-pushed
the
events-tests
branch
from
5bd8b13
to
7c64ae5
Compare
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
gianarb
approved these changes
Dec 24, 2020
gauravgahlot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds DB tests for hardware events (CUD).
Checklist:
I have: