Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent user experience across tink-cli list command -q #403

Closed
gianarb opened this issue Dec 24, 2020 · 2 comments · Fixed by #404
Closed

Consistent user experience across tink-cli list command -q #403

gianarb opened this issue Dec 24, 2020 · 2 comments · Fixed by #404
Assignees
@gauravgahlot
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gianarb
Copy link
Contributor

gianarb commented Dec 24, 2020

#402

@gauravgahlot I think changes in user experience should be discussed together first, and second, we have to try to be as consistent as possible in the CLI. (we are pretty bad with that)

Can you add the same change you made here for the other resources?

Thanks
@gauravgahlot
Copy link
Contributor

Apologies, I should have submitted a proposal first. I'm already in progress to make it consistent across the CLI.

@gauravgahlot gauravgahlot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 24, 2020
@gianarb
Copy link
Contributor Author

gianarb commented Dec 24, 2020 •
edited
Loading

Well, no need for a proposal for that and no need to apologise :) but just an issue is fine or even a PR with a bit more time to handle that, anyway, overall the feature is good and needed so thank you for that! We just have to port it to all the other commands so people will have a more friendly experience using the CLI

@gauravgahlot gauravgahlot mentioned this issue Dec 28, 2020
Merged
3 tasks
@mergify mergify bot closed this as completed in #404 Dec 28, 2020
mergify bot added a commit that referenced this issue Dec 28, 2020
@mergify
Fixed: consistent user experience across tink-cli list command -q (#404)
d7856c9 
## Description

The PR introduces a new flag --quiet or -q to only display IDs while listing hardware and workflow.

```
/ # tink hardware list
+--------------------------------------+-------------------+-------------+-----------+
| ID                                   | MAC ADDRESS       | IP ADDRESS  | HOSTNAME  |
+--------------------------------------+-------------------+-------------+-----------+
| 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a95 | 08:00:27:00:00:01 | 192.168.1.5 | server001 |
| 1eba0bf8-3772-4b4a-ab9f-6ebe93b90a95 | 08:00:27:00:00:02 | 192.168.1.5 | server001 |
+--------------------------------------+-------------------+-------------+-----------+

/ # tink hardware list -q
0eba0bf8-3772-4b4a-ab9f-6ebe93b90a95
1eba0bf8-3772-4b4a-ab9f-6ebe93b90a95

/ # tink workflow list
+--------------------------------------+--------------------------------------+-----------------------------------+-------------------------------+-------------------------------+
| WORKFLOW ID                          | TEMPLATE ID                          | HARDWARE DEVICE                   | CREATED AT                    | UPDATED AT                    |
+--------------------------------------+--------------------------------------+-----------------------------------+-------------------------------+-------------------------------+
| c465b4b2-48e6-11eb-a673-0242ac120004 | aabad754-48e6-11eb-a673-0242ac120004 | {"device_1": "08:00:27:00:00:02"} | 2020-12-28 08:29:13 +0000 UTC | 2020-12-28 08:29:13 +0000 UTC |
| c7812ec3-48e6-11eb-a673-0242ac120004 | aabad754-48e6-11eb-a673-0242ac120004 | {"device_1": "08:00:27:00:00:02"} | 2020-12-28 08:29:19 +0000 UTC | 2020-12-28 08:29:19 +0000 UTC |
+--------------------------------------+--------------------------------------+-----------------------------------+-------------------------------+-------------------------------+

/ # tink workflow list -q
c465b4b2-48e6-11eb-a673-0242ac120004
c7812ec3-48e6-11eb-a673-0242ac120004
```

## Why is this needed

Fixes: #403 

## How Has This Been Tested?

Tested manually over the vagrant setup.

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [x] provided instructions on how to upgrade
@gianarb gianarb mentioned this issue Dec 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravgahlot gauravgahlot

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: consistent user experience across tink-cli list command -q gauravgahlot/tink
2 participants
@gianarb @gauravgahlot