Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the file pull via curl is not robust and sometimes fail with out error / abort the script #306

Closed
MaxPeal opened this issue Sep 23, 2020 · 2 comments · Fixed by #519 or #537
Closed

the file pull via curl is not robust and sometimes fail with out error / abort the script #306

MaxPeal opened this issue Sep 23, 2020 · 2 comments · Fixed by #519 or #537
Assignees
@tstromberg
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@MaxPeal
Copy link
Contributor

MaxPeal commented Sep 23, 2020 •
edited
Loading

the file pull via curl is not robust and sometimes fail with out error / abort the script

Expected Behaviour

curl must catch the errors and abort the script.

Current Behaviour

curl will fail silently

Possible Solution

see the PR #305

Steps to Reproduce (for bugs)

have a unstabel network

Your Environment

local Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):
    linux
  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
    Vagrant & VirtualBox
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 27, 2021
@displague displague mentioned this issue Aug 10, 2021
Merged
3 tasks
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
@tstromberg
Copy link
Contributor

tstromberg commented Aug 27, 2021 •
edited
Loading

It took me a few times to understand the issue, so I'll clarify it for others: the request here is if the curl fails, the script should abort.

@mergify mergify bot closed this as completed in #519 Sep 1, 2021
mergify bot added a commit that referenced this issue Sep 1, 2021
@mergify
Docker compose download link (#519)
aaf6a8e 
## Description

Rebase of #305 (@MaxPeal) with reviewer requested changes applied.

notably, this variation on the original PR does not include `curl --progress`.

## Why is this needed

Fixes: #306

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@tstromberg tstromberg reopened this Sep 1, 2021
@tstromberg
Copy link
Contributor

Reopening because #519 does not actually fix the issue.

@tstromberg tstromberg mentioned this issue Sep 1, 2021
Closed
@tstromberg tstromberg self-assigned this Sep 1, 2021
@jacobweinstock jacobweinstock mentioned this issue Sep 3, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
2 participants
@tstromberg @MaxPeal