Skip to content

Commit

Permalink
tink-cli: Add bash to container image
Browse files Browse the repository at this point in the history
I've recently been bitten by alpine/busybox's ash not properly implementing
`[[` as a builtin while doing a bunch of work on sandbox's scripts. Changing
over to POSIX sh is an option but not really worth it imo as almost everyone
assumes sh == bash already and bash is also nice for interactive use anyway.

Bash ends up adding ~2.2MB to the image which I don't think matters, tink-cli
isn't going to be used in production all that much and its still pretty small.

tink-cli-yes-bash                latest            3f59f8e81a34   10 seconds ago   30.4MB
tink-cli-no-bash                 latest            e521b3895111   23 seconds ago   28.2MB

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
  • Loading branch information
mmlb committed Mar 10, 2022
1 parent 2326b77 commit efc33b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/tink-cli/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ CMD sleep infinity
ARG TARGETARCH
ARG TARGETVARIANT

RUN apk add --no-cache --update --upgrade ca-certificates
RUN apk add --no-cache --update --upgrade bash ca-certificates
COPY tink-cli-linux-${TARGETARCH:-amd64}${TARGETVARIANT} /usr/bin/tink

0 comments on commit efc33b6

Please sign in to comment.