Fix 0.3 CAPI version mapping #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
chrisdoherty4
force-pushed
the
patch/fix-capt-api-mapping
branch
from
d89224f
to
c0b1617
Compare
| @@ -1,7 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm assuming that this isn't used anywhere?
There was a problem hiding this comment.
No. Its a CAPI development thing that you can use, see https://cluster-api.sigs.k8s.io/clusterctl/developers.html.
The file is an incomplete configuration. I gave it a whirl and clusterctl errored out requiring more info. I fixed it up but other problems ensued. In any case, its not used by the project explicitly and requires a checkout of CAPI.
jacobweinstock
approved these changes
Sep 28, 2022
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b641deb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a CAPI version mapping to CAPT. The version mapping is metadata used by CAPI when installing the infrastructure provider and it must include the provider version being deployed. This doesn't really fix the problem as we don't intend on cutting a v0.3.1 with the change but it at least creates a record in the history.
v0.4.0 will be cut in the coming weeks.
Additionally update the quick start with URLs that are usable.