Maintainership Application #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
requested review from
detiber,
displague and
micahhausler
as code owners
Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
chrisdoherty4
force-pushed
the
maintainership
branch
from
3333ec3
to
82cb513
Compare
displague
approved these changes
Aug 22, 2022
micahhausler
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
LGTM, but since we're dropping @detiber can we get him to +1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with the loss of an existing maintainer I'm applying for maintainership as I try to drive releasing of CAPT. Having developed Rufio it makes sense to also be a maintainer of CAPT so I think there's an element of fast-tracking at play that's been principally agreed by maintainers already.
Additionally, this PR reduces @detiber to approver as they've stepped back from Tinkerbell. There's no governance around this currently but this feels like an appropriate move even if detiber can't contribute much.