allow filtering for hardware by label selector #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzneal
commented
Apr 29, 2022
micahhausler
suggested changes
Apr 29, 2022
tzneal
force-pushed
the
allow-selecting-hardware-by-label-selector
branch
3 times, most recently
from
db3ac93
to
8fe30f5
Compare
tzneal
force-pushed
the
allow-selecting-hardware-by-label-selector
branch
from
8fe30f5
to
c5a0bb2
Compare
micahhausler
suggested changes
May 2, 2022
tzneal
force-pushed
the
allow-selecting-hardware-by-label-selector
branch
from
c5a0bb2
to
e2dcb98
Compare
micahhausler
reviewed
May 2, 2022
- add LabelSelector to TinkerbellMachineSpec - use the selector when querying for Hardware Signed-off-by: Todd Neal <tnealt@amazon.com>
tzneal
force-pushed
the
allow-selecting-hardware-by-label-selector
branch
from
e45d620
to
563487d
Compare
micahhausler
approved these changes
May 2, 2022
mergify bot
added a commit
that referenced
this pull request
May 2, 2022
Signed-off-by: Micah Hausler <mhausler@amazon.com> ## Description Added quickstart docs example for #162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows filtering hardware by required and preferred hardware affinities.
Why is this needed
Previously hardware selection was performed by listing available hardware and choosing the first available. This change enables filtering by required and preferred labels on the hardware.
How Has This Been Tested?
Unit testing only
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: