Miscellaneous fixes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
detiber
force-pushed
the
fixes
branch
2 times, most recently
from
5e14258
to
4ceb271
Compare
invidian
suggested changes
Dec 10, 2020
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "name": "infrastructure-tinkerbell", | |||
There was a problem hiding this comment.
Do we want it infrastructure-tinkerbell or infrastructure-tink ? #11
There was a problem hiding this comment.
Oh, I see next commits now.
There was a problem hiding this comment.
I think we want tinkerbell here, since this will be used by clusterctl for output.
| @@ -8,5 +8,5 @@ spec: | |||
| spec: | |||
| containers: | |||
| # Change the value of image field below to your controller image URL | |||
| - image: quay.io.io/tinkerbell/cluster-api-provider-tinkerbell:e2e | |||
There was a problem hiding this comment.
Hehe, I run into this one as well 😄
| @@ -1,11 +1,11 @@ | |||
| # Adds namespace to all resources. | |||
| namespace: cluster-api-provider-tinkerbell-system | |||
| namespace: capt-system | |||
There was a problem hiding this comment.
Yes, this was a fix for #11
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
- Switch to capt- as a prefix instead of cluster-api-provider-tinkerbell to avoid issues with name length - regenerate manifests to pick up name prefix change and reflect the current state of things Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
|
@invidian this should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various fixes
Why is this needed
.iomake crdsto pick up the above changes and also reflect the current state of thingsFixes: #11