-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Extract ip address directly from interface. #112
base: master
Are you sure you want to change the base?
Conversation
I just merged your changes. I had to merge a few changes from other PRs. I included you in the commit messages: cb7b180 |
Had to revert the PR because netif is not compatible with alpine linux. Let me know if you have time to investigate a solution for alpine linux that is compatible with your netif solution. |
Sure, I'll look into it when I have time. |
@timothymiller |
Signed-off-by: Comic Chang <comicchang@gmail.com>
Hi, I've removed the netifaces dependency, reimplemented in pure python, rebased to the latest master, and tested it. Please review the commit. |
That sounds like a fine trade off @comicchang since the primary way of running this will be in a Linux container. |
@comicchang @timothymiller Maybe allowing users to customize the IP query command would be a more flexible solution? This would solve the cross-platform issue and provide greater flexibility. |
Sounds good to me! |
Another PR to allow running custom script to get IPv4 & 6 address #131 |
Directly extract ip address from network interface.
Useful if you:
config file: