do not match when too many args provided

timkindberg · Oct 22, 2020 · 26abfc6 · 26abfc6
1 parent eb32c67
commit 26abfc6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/when.js b/src/when.js
@@ -66,7 +66,10 @@ class WhenMock {
           // Do not let a once mock match more than once
           if (once && called) continue
 
-          const isMatch = matchers.reduce(checkArgumentMatchers(expectCall, args), true)
+          const isMatch =
+            args.length <= matchers.length &&
+            matchers.reduce(checkArgumentMatchers(expectCall, args), true)
+
           if (isMatch) {
             this.callMocks[i].called = true
             return typeof returnValue === 'function' ? returnValue(...args) : returnValue

diff --git a/src/when.test.js b/src/when.test.js
@@ -164,6 +164,8 @@ describe('When', () => {
         .mockReturnValue('x')
 
       expect(fn(1, 'foo', true, 'whatever')).toEqual('x')
+      expect(fn(1, 'foo', true)).toEqual(undefined)
+      expect(fn(1, 'foo', true, 'whatever', undefined, 'oops')).toEqual(undefined)
       expect(spyEquals).toBeCalledWith(1, 1)
       expect(spyEquals).toBeCalledWith('foo', 'foo')
       expect(spyEquals).toBeCalledWith(true, true)