-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for "compressed data is corrupt" in float8 compression #6689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6689 +/- ##
==========================================
+ Coverage 80.06% 81.50% +1.43%
==========================================
Files 190 191 +1
Lines 37181 36422 -759
Branches 9450 9465 +15
==========================================
- Hits 29770 29684 -86
+ Misses 2997 2972 -25
+ Partials 4414 3766 -648 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you know which commit fixes this on main?
I think the fix is here, but haven't checked tbh: 4f2f658#diff-587fcbff3131f2ebe9b1a17f2bf8dfb532f92653fee332f8b6395ceb61eb0219R92 |
The bug itself is already fixed in the main branch.
ad83487
to
acc2e4a
Compare
For some reason I didn't realize then that this is an actual bug and we have to backport the fix :) |
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
The bug itself is already fixed in the main branch.
Fixes #6681
Disable-check: force-changelog-file