Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for decompression #6411

Merged
merged 1 commit into from
Dec 20, 2023
Merged

More tests for decompression #6411

merged 1 commit into from
Dec 20, 2023

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Dec 12, 2023

Add separate testing for bulk and row-by-row decompression, so that the errors in one don't mask the errors in the other.

Also add fuzzing for row-by-row decompression, for text columns as well.

Disable-check: force-changelog-file

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (1797f8e) 87.30% compared to head (cfad382) 87.29%.

Files Patch % Lines
.../src/compression/decompress_arithmetic_test_impl.c 76.25% 10 Missing and 9 partials ⚠️
tsl/src/compression/decompress_text_test_impl.c 71.66% 14 Missing and 3 partials ⚠️
tsl/src/compression/compression_test.c 87.50% 11 Missing and 2 partials ⚠️
tsl/src/compression/array.c 85.71% 0 Missing and 1 partial ⚠️
tsl/src/compression/compression.c 66.66% 0 Missing and 1 partial ⚠️
tsl/src/compression/compression.h 0.00% 0 Missing and 1 partial ⚠️
tsl/src/compression/dictionary.c 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6411      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.02%     
==========================================
  Files         185      187       +2     
  Lines       41744    41774      +30     
  Branches     9283     9293      +10     
==========================================
+ Hits        36445    36467      +22     
- Misses       3618     3634      +16     
+ Partials     1681     1673       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm mentioned this pull request Dec 12, 2023
7 tasks
@akuzm akuzm marked this pull request as ready for review December 14, 2023 15:30
Copy link

@gayyappan, @fabriziomello: please review this pull request.

Powered by pull-review

Copy link
Contributor

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add separate testing for bulk and row-by-row decompression, so that the
errors in one don't mask the errors in the other.

Also add fuzzing for row-by-row decompression, for text columns as well.
@akuzm akuzm enabled auto-merge (rebase) December 20, 2023 10:45
@akuzm akuzm merged commit 4f2f658 into timescale:main Dec 20, 2023
52 of 54 checks passed
@akuzm akuzm deleted the fuzzing branch December 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants