Include both pgx 0.2.x and pgx 0.4.x in CI image #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're updating our pgx dependency to 0.4 series, and using `cargo-pgx install` with pgx 0.4.x inside the update-tester causes problems. Starting in 0.4, pgx changed it's SQL generation and gives the following error when running `cargo pgx install` inside the update tester with previous versions of the toolkit checked out: found `pgx` 0.2-0.3 series SQL generation while using `cargo-pgx` 0.4 series. As a solution, we're changing the docker image used in our CI setup to include 0.2 series version of pgx installed at /pgx/0.2 as well as a 0.4 series version of pgx installed at /pgx/0.4 so that we can run the update tester with the appropriate `cargo-pgx` subcommand.
JLockerman
approved these changes
May 11, 2022
There was a problem hiding this comment.
Looks right to me 👍
(and the CI builder test seems to be running 😋)
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
May 12, 2022
418: `update-tester` requires two versions of `cargo-pgx` r=rtwalker a=rtwalker Now that #417 is merged, we can change the `update-tester` crate to require two versions of `pgx` to be installed: * a 0.2-0.3 series pgx aka "old" * a 0.4 series or newer pgx (we don't actually use this one yet, but we will after #408) Rather than insisting on having the `pgx`s installed in a specific location, the update tester takes in paths to the `*/bin/cargo-pgx` subcommands as arguments and then inspects the `Cargo.toml` during the checkout of each release to determine which one to invoke. I've also updated the `tools/build` script and the `.github/workflows/ci.yml` to use the new update tester. Went ahead and bumped the `update-tester` version to `0.2.0` so I could more easily tell the difference while testing locally, though it probably makes little practical difference. Co-authored-by: Ryan Walker <rwalker@timescale.com>
bors bot
added a commit
that referenced
this pull request
May 12, 2022
418: `update-tester` requires two versions of `cargo-pgx` r=rtwalker a=rtwalker Now that #417 is merged, we can change the `update-tester` crate to require two versions of `pgx` to be installed: * a 0.2-0.3 series pgx aka "old" * a 0.4 series or newer pgx (we don't actually use this one yet, but we will after #408) Rather than insisting on having the `pgx`s installed in a specific location, the update tester takes in paths to the `*/bin/cargo-pgx` subcommands as arguments and then inspects the `Cargo.toml` during the checkout of each release to determine which one to invoke. I've also updated the `tools/build` script and the `.github/workflows/ci.yml` to use the new update tester. Went ahead and bumped the `update-tester` version to `0.2.0` so I could more easily tell the difference while testing locally, though it probably makes little practical difference. Co-authored-by: Ryan Walker <rwalker@timescale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating our pgx dependency to 0.4 series, and using
cargo-pgx installwith pgx 0.4.x inside the update-tester causes problems.Starting in 0.4, pgx changed it's SQL generation and gives the following error when running
cargo pgx installinside the update tester with previous versions of the toolkit checked out:found
pgx0.2-0.3 series SQL generation while usingcargo-pgx0.4 series.As a solution, we're changing the docker image used in our CI setup to include 0.2 series version of pgx installed at /pgx/0.2 as well as a 0.4 series version of pgx installed at /pgx/0.4 so that we can run the update tester with the appropriate
cargo-pgxsubcommand.