Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of Parsed test #665

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

This test is failing on latest rust nightly (since rust-lang/rust#116672) and in rustc_codegen_gcc in the sync we're currently doing. Instead of having cfg, simpler to compare with u128 type alignment directly, like that it will work in both nightly and the current version.

@GuillaumeGomez
Copy link
Contributor Author

As for the CI failing, seems like error messages got updated. Want me to include a commit to fix them?

@jhpratt
Copy link
Member

jhpratt commented Feb 18, 2024

That one CI check has been failing for a little while now due to rust-lang/rust#119273.

Delegating alignment to what it is for i128 is definitely the smart thing to do. Thanks!

@jhpratt jhpratt merged commit 4f77df1 into time-rs:main Feb 18, 2024
19 of 20 checks passed
@GuillaumeGomez GuillaumeGomez deleted the parsed-alignment branch February 18, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants