Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #740] Add more logs in getregionstore #751

Merged
merged 8 commits into from
May 31, 2023

Conversation

shiyuhang0
Copy link
Collaborator

@shiyuhang0 shiyuhang0 commented May 25, 2023

What problem does this PR solve?

Issue Number: close #750

Problem Description: TBD

What is changed and how does it work?

  • Add more logs

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.26 🎉

Comparison is base (71676ee) 37.89% compared to head (d915e50) 38.15%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #751      +/-   ##
============================================
+ Coverage     37.89%   38.15%   +0.26%     
- Complexity     1611     1618       +7     
============================================
  Files           278      278              
  Lines         17511    17517       +6     
  Branches       1991     1992       +1     
============================================
+ Hits           6636     6684      +48     
+ Misses        10208    10160      -48     
- Partials        667      673       +6     
Impacted Files Coverage Δ
...ain/java/org/tikv/common/region/RegionManager.java 79.32% <66.66%> (-0.44%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shiyuhang0 shiyuhang0 changed the title [fix #740] Optimize getregionstore logical [fix #740] Add more logs in getregionstore May 25, 2023
shiyuhang0 and others added 5 commits May 25, 2023 21:23
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 and others added 3 commits May 29, 2023 13:56
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@shiyuhang0
Copy link
Collaborator Author

/cherry-pick release-3.3

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.3: #752.

@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request could not be created: failed to create pull request against tikv/client-java#release-3.3 from head ti-chi-bot:cherry-pick-751-to-release-3.3: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-751-to-release-3.3."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

shiyuhang0 added a commit that referenced this pull request May 31, 2023
* optimize getregionstore logical

Signed-off-by: shiyuhang <1136742008@qq.com>

* decrease impact

Signed-off-by: shiyuhang <1136742008@qq.com>

* Update RegionManager.java

Signed-off-by: shiyuhang <1136742008@qq.com>

* Fix health checking issue (#748)

Signed-off-by: shiyuhang <1136742008@qq.com>

* Update RegionManager.java

Signed-off-by: shiyuhang <1136742008@qq.com>

* add log

Signed-off-by: shiyuhang <1136742008@qq.com>

* change log level

Signed-off-by: shiyuhang <1136742008@qq.com>

---------

Signed-off-by: shiyuhang <1136742008@qq.com>
Co-authored-by: shiyuhang <1136742008@qq.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement ha
3 participants