-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to #556] metrics: attach cluster label to metrics #558
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
…h-cluster-id Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
============================================
- Coverage 33.13% 33.05% -0.08%
+ Complexity 1339 1328 -11
============================================
Files 270 270
Lines 17054 17131 +77
Branches 1950 1950
============================================
+ Hits 5651 5663 +12
- Misses 10794 10866 +72
+ Partials 609 602 -7
Continue to review full report at Codecov.
|
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since each session is connected to a tikv cluster, can you init the cluster id when TiSession
is created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
…h-cluster-id Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #579 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.2 in PR #580 |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: to #556
Problem Description:
Add
cluster
label for metrics in client-java with the value of cluster id.