[to #423] add some guideline for triage critical bugs #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
zz-jason
force-pushed
the
docs/defect-severity
branch
from
1c20c5b
to
d563550
Compare
iosmanthus
reviewed
Feb 10, 2022
| in this defect, gRPC timeout is not set for certain requests, which causes the | ||
| requests can not be terminated as expected when the processing time is too long. | ||
|
|
||
| ### Major Defects |
There was a problem hiding this comment.
Should we add some brief description for these three lower defects? Or this guideline is still WIP.
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
|
LGTM |
ti-srebot
approved these changes
Feb 14, 2022
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: to #423
Problem Description: the contribution guide lack guidelines about trading bugs.
What is changed and how does it work?
This PR adds a guideline for triaging critical bugs with one example.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes