-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #465] implement AutoClosable for TwoPhaseCommitter #466
Conversation
close tikv#465 Signed-off-by: Peng Guanwen <pg999w@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some tests about the behavior of AutoCloseable
?
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999 please fix the failure reported by license checker |
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
/merge |
/run-all-tests |
What problem does this PR solve?
Issue Number: close #465
Problem Description: implement AutoClosable for TwoPhaseCommitter
What is changed and how it works?
Code changes
Check List for Tests
This PR has been tested by the at least one of the following methods:
Side effects
Related changes