-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #419] upgrade kvproto to fix rawBatchPut compatibility #441
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
DNM until pingcap/kvproto#844 merged. |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
This pull request can review now @zz-jason @marsishandsome @birdstorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some tests?
We may create another pull request to cover this issue because the tests might expose other issues of compatibility. |
i think there are compatibility problems relating to kvproto version change. Is there any description about the affected versions? |
It is described in #419, the master branch of client-java can not access TiKV with a version lower than 5.3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iosmanthus could you add some test?
/run-all-tests tikv = release-5.0 |
@zz-jason PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@iosmanthus merge failed. |
/merge |
/run-all-tests |
@iosmanthus merge failed. |
/run-all-tests |
/merge |
/run-all-tests |
@iosmanthus merge failed. |
/merge |
/run-all-tests |
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #419
Problem Description:
rawBatchPut
can access TiKV (version < v5.3.0)What is changed and how it works?
Upgrading kvproto to fix the forward compatibility of RawBatchPutRequest.
Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes