-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #433] fix calling getStoreById without backoffer #434
[close #433] fix calling getStoreById without backoffer #434
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67e5ff1
to
b757b2b
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some tests.
@@ -185,6 +184,7 @@ public boolean canRetryAfterSleep(BackOffFunction.BackOffFuncType funcType, long | |||
} | |||
} | |||
|
|||
SlowLogSpan slowLogSpan = getSlowLog().start("backoff " + funcType.name()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why move it here? should BACKOFF_DURATION
also be moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a return
in line 184, which will cause "end":"N/A",
.
it's hard to understand it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got. then why not move BACKOFF_DURATION
to here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these lines to here might cause we can't see the backoff in slow log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may end this span while returning though we will see this backoff end shortly but this span is still there.
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
b757b2b
to
ab8cf80
Compare
/run-all-tests |
ab8cf80
to
5afd1b9
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
5afd1b9
to
1933ca1
Compare
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
/run-all-tests |
1 similar comment
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #440 |
Rest LGTM |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Signed-off-by: marsishandsome <marsishandsome@gmail.com>
close #433
Timeout in seekLeaderStore is not limited.
We should use
backoffer
for all the gRPC calls.