-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #421] add timelines tool for slow log #420
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference with scripts
, what kind of code is expected to be put in scripts
and tools
respectively?
scripts might be some shell script or python script to build the project, it might be more appropriate to put the tool into |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this PR changes the release logic?
Before: mvn clean package -DskipTests
After: build tools? release tools binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend writing the tool in Java and release in the same tikv-java-client jar, so that users can run the tools directly without another executable binary.
…-java into add-slow-log-timelines
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@zz-jason @marsishandsome PTAL |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
This tool will not change the release logic, it is a dependent binary tool to parse slow log instead of a library. |
/run-all-tests |
/run-all-tests release-5.0 |
/run-all-tests tikv = release-5.0 |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@zz-jason PTAL |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@zz-jason PTAL |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@zz-jason PTAL |
/run-all-tests |
1 similar comment
/run-all-tests |
@zz-jason @marsishandsome PTAL |
This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days. |
I'm going to close this PR since it hasn't been updated for a long time. Feel free to reopen it once you wish to advance this PR in the future. |
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
close: #421
Increasing the read readability of the slow log, add a timeline to illustrate the slow log process.
What is changed and how it works?
This tool parses the existing logs of client-java and extracts the slow log, then converts them into timelines.
Three arguments are provided:
text:
Check List for Tests
This PR has been tested by at least one of the following methods: