Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #380] make gRPC idle timeout configurable #379

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

sunxiaoguang
Copy link
Member

@sunxiaoguang sunxiaoguang commented Dec 9, 2021

Signed-off-by: Xiaoguang Sun sunxiaoguang@pingcap.com

What problem does this PR solve?

Make gRPC idle timeout configurable

What is changed and how it works?

Make gRPC idle timeout configurable

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

closes: #380

Signed-off-by: Xiaoguang Sun <sunxiaoguang@pingcap.com>
Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason changed the title Make gRPC idle timeout configurable [close #380] make gRPC idle timeout configurable Dec 9, 2021
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit d8841e7 into tikv:master Dec 9, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #382

ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gRPC idle timeout configurable
5 participants