-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuration property file #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
marsishandsome
requested review from
birdstorm,
andylokandy and
Little-Wallace
October 27, 2021 08:23
marsishandsome
force-pushed
the
feature/conf-file
branch
from
October 27, 2021 08:24
f130a12
to
7658712
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/conf-file
branch
from
October 27, 2021 08:25
7658712
to
ad6a7f4
Compare
/run-all-tests |
Little-Wallace
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
birdstorm
reviewed
Oct 27, 2021
birdstorm
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented
birdstorm
approved these changes
Oct 27, 2021
ti-srebot
approved these changes
Oct 27, 2021
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Oct 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #296 |
marsishandsome
added a commit
that referenced
this pull request
Oct 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
Support configuration property file
What is changed and how it works?
add parameter tikv.config_file
This parameter can be passed by
-Dtikv.config_file=/path/to/tikv_client_config.properties
.Here is an example of
tikv_client_config.properties
.Check List
Tests
Code changes
Side effects
Related changes