Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDClient: Add function to call pause checker API #277

Merged
merged 12 commits into from
Sep 28, 2021
Merged

PDClient: Add function to call pause checker API #277

merged 12 commits into from
Sep 28, 2021

Conversation

peng1999
Copy link
Member

@peng1999 peng1999 commented Sep 16, 2021 •
edited
Loading

Signed-off-by: Peng Guanwen pg999w@outlook.com

What problem does this PR solve?

#268 needs to call pause checker in Java client. This PR adds the function.

What is changed and how it works?

Added functions:

  • PDClient.keepPauseChecker
  • PDClient.stopKeepPauseChecker
  • PDClient.resumeChecker

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to be included in the release note

@peng1999
PDClient: Add function to call pause checker API
4f14503 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999 peng1999 marked this pull request as ready for review September 16, 2021 12:27
@peng1999
Copy link
Member Author

/cc @marsishandsome

@peng1999
bugfix
9e26995 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Add resumeChecker
83d74d4 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Add isCheckerPaused
4415fcb 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

marsishandsome
marsishandsome reviewed Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this PR after tikv/pd#4092 is merged

@marsishandsome
Copy link
Collaborator

run mvn clean package -DskipTests to format the code

@peng1999 @marsishandsome
Refine test
2e46d07 
Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

@peng1999
Reformat code
34bad19 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@marsishandsome
Copy link
Collaborator

/run-all-tests

2 similar comments
@marsishandsome
Copy link
Collaborator

/run-all-tests

@marsishandsome
Copy link
Collaborator

/run-all-tests

@peng1999
Remove scheduler after shutdown
430654b 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

@peng1999
Reformat code
6565d38 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

/run-all-tests

@peng1999
Copy link
Member Author

/run-all-tests

@peng1999
Reformat code
85479ef 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

/run-all-tests

@peng1999
Add synchronized to keepPauseChecker
a973328 
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
marsishandsome
marsishandsome approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

/run-all-tests

@marsishandsome marsishandsome merged commit d543ae7 into tikv:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

Assignees
No one assigned
Labels
first-time-contributor status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peng1999 @marsishandsome @ti-srebot