Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround: disable TxnKV test #271

Merged
merged 1 commit into from
Sep 2, 2021
Merged

workaround: disable TxnKV test #271

merged 1 commit into from
Sep 2, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Sep 2, 2021 •
edited
Loading

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

#270

This PR breaks compatibility tikv/tikv#10800.

What is changed and how it works?

disable TxnKV test as workaround

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome mentioned this pull request Sep 2, 2021
Closed
@marsishandsome
workaround: disable TxnKV test because of tikv#270
033312c 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit ebe1edc into tikv:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsishandsome @birdstorm @ti-srebot