-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RawKVClient CAS API #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
force-pushed
the
feature/refactor-cas
branch
2 times, most recently
from
June 23, 2021 09:37
caa5e5d
to
eeac001
Compare
/run-all-tests |
marsishandsome
force-pushed
the
feature/refactor-cas
branch
from
June 23, 2021 09:42
eeac001
to
aef33b7
Compare
/run-all-tests |
marsishandsome
force-pushed
the
feature/refactor-cas
branch
2 times, most recently
from
June 23, 2021 09:46
3ecb012
to
d2cd027
Compare
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/refactor-cas
branch
from
June 23, 2021 09:50
d2cd027
to
d0afb12
Compare
/run-all-tests |
birdstorm
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andylokandy
approved these changes
Jun 23, 2021
ti-srebot
approved these changes
Jun 23, 2021
marsishandsome
force-pushed
the
feature/refactor-cas
branch
from
June 24, 2021 03:47
8512a53
to
2a7ef84
Compare
/run-all-tests |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #212
Currently, users should pass the parameter
atomic
to funcions likeput
、batchPut
、delete
、batchDelete
when usingCAS
inRawKVClient
.What is changed and how it works?
Add a config
tikv.enable_atomic_for_cas
replacing theatomic
parameter on each write function likeput
、delete
.Check List
Tests
Code changes
Side effects
Related changes