Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove autoware_auto_msgs references #122

Closed

Conversation

xmfcx
Copy link

@xmfcx xmfcx commented Jul 18, 2024

PR Type

  • New Feature

Related Links

Description

This PR aims to remove remaning autoware_auto_msgs references from the packages in this repository and let the rest of the Autoware build without the autoware_auto_msgs.

I've removed all code and some documentation references. But there are still some readme references left but I think it's mostly outdated anyways so it shouldn't matter at this point.

Review Procedure

Perform a clean compilation of latest Autoware with autoware_auto_msgs removed from the repository.
You may use:

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

xmfcx and others added 2 commits July 18, 2024 17:12
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx
Copy link
Author

xmfcx commented Jul 18, 2024

@xmfcx
Copy link
Author

xmfcx commented Jul 18, 2024

https://github.com/autowarefoundation/autoware/actions/runs/9993281928/job/27620306211?pr=5011 has passed and it compiles with cuda on my machine with the latest Autoware (2024-07-18).

Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These APIs define the output type as auto_msgs in their specifications, so it cannot be changed. Currently, all APIs other than the RTC API are deprecated, so I'm considering removing the reference to this repository.

@xmfcx xmfcx closed this Jul 18, 2024
@xmfcx xmfcx deleted the feat/remove-autoware-auto-msgs branch July 18, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants