Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dispatch release note #29

Merged
merged 2 commits into from
Apr 6, 2023
Merged

ci: dispatch release note #29

merged 2 commits into from
Apr 6, 2023

Conversation

shmpwk
Copy link

@shmpwk shmpwk commented Apr 5, 2023

PR Type

  • New Feature

Related Links

tier4/autoware.universe#313
tier4/autoware.universe#315

Description

This workflow triggers the repository: TIER4_INTERNAL_LINK to update the spreadsheets for release note.
The timing of this repository dispatch is committing to tier4/main default branch .

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk shmpwk changed the title Feat/dispatch release note ci: dispatch release note Apr 5, 2023
@shmpwk shmpwk enabled auto-merge April 5, 2023 07:39
@shmpwk
Copy link
Author

shmpwk commented Apr 5, 2023

This CI has already checked in autoware.universe, so just approval might be ok without thorough checking
Also, you cannot checkt CI without merging this.

@shmpwk
Copy link
Author

shmpwk commented Apr 6, 2023

@tkimura4 @1222-takeshi @taikitanaka3
friendly reminder

Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit cca4221 into tier4/main Apr 6, 2023
@shmpwk shmpwk deleted the feat/dispatch-release-note branch April 6, 2023 01:07
@shmpwk
Copy link
Author

shmpwk commented Apr 6, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants