Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): fix typo in param name and change default value #271

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

kminoda
Copy link

@kminoda kminoda commented Jan 12, 2024

Description

Fix typo in param name and also change default value so that it publishes default value

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… value (autowarefoundation#785)

* fix(multi_object_tracker): fix typo in param name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* feat: update default param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title feat(multi_object_tracker): fix typo in param name and change default… feat(multi_object_tracker): fix typo in param name and change default value Jan 12, 2024
Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit b5e63b7 into beta/v0.20.0 Jan 12, 2024
11 of 12 checks passed
@tkimura4 tkimura4 deleted the hotfix/multi_object_tracker/change_param branch January 12, 2024 12:03
t4-adc pushed a commit that referenced this pull request Apr 3, 2024
…on (#271)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants