Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Ros2 v0.8.0 fix packages #64

Merged

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Feb 22, 2021

add vehicle_param_file to simple_planning_simulator/lane_change_planner

@@ -18,6 +18,7 @@
<include file="$(find-pkg-share vehicle_launch)/launch/vehicle.launch.xml">
<arg name="vehicle_model" value="$(var vehicle_model)"/>
<arg name="sensor_model" value="$(var sensor_model)"/>
<arg name="vehicle_param_file" value="$(find-pkg-share $(var vehicle_model)_description)/config/vehicle_info.yaml"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vehicle_info.yaml will be renamed at tier4/lexus_description.iv.universe#11. cc @kenji-miyake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create another PR after this is merged!

@wep21 wep21 added the ros2-v0.8.0 update ros2 branch to v0.8.0 label Feb 24, 2021
Copy link
Contributor

@k0suke-murakami k0suke-murakami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0suke-murakami k0suke-murakami merged commit f5b8579 into tier4:ros2-v0.8.0-beta Feb 24, 2021
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
* feat: add sync-universe-param-files

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix path

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix sync name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* deal with review

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 pushed a commit that referenced this pull request Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ros2-v0.8.0 update ros2 branch to v0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants