Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: change logging_simulator.launch arg value #156

Closed
wants to merge 2 commits into from
Closed

feat: change logging_simulator.launch arg value #156

wants to merge 2 commits into from

Conversation

hayato-m126
Copy link

@hayato-m126 hayato-m126 commented Dec 13, 2021 •
edited by KeisukeShima
Loading

PR Type

  • Improvement

Related Links

#462

Description

  • This PR fixes a link above that caused dummy_perception_publisher to output an empty point cloud.

Review Procedure

  • arg name="scenario_simulation" value="true" in Simulator Section

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@github-actions github-actions bot added the main label Dec 13, 2021
KeisukeShima
KeisukeShima approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hayato-m126
Copy link
Author

@kenji-miyake
I edited the launch file and pushed it.
I'd like to merge it if this is okay.

kenji-miyake
kenji-miyake approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yukkysaito
Copy link
Collaborator

Can I merge this?

@hayato-m126
Copy link
Author

Yes, Please

@yukkysaito
Copy link
Collaborator

@kenji-miyake Has the merge authority changed?

@kenji-miyake
Copy link
Contributor

Ah, the target is main. Should it be use-autoware-auto-msgs?

@kenji-miyake
Copy link
Contributor

@hayato-m126 Could you confirm the target branch? If you'd like to merge to main, you should send a PR to our internal repository.

@hayato-m126
Copy link
Author

@kenji-miyake
I made same PR to internal repository

@hayato-m126
Copy link
Author

I close this PR because the PR to internal repository is merged.

@kenji-miyake kenji-miyake deleted the feature/logging-simulator-launch-arg-vlaue branch December 22, 2021 01:18
@kenji-miyake
Copy link
Contributor

Thank you! FYI, it's synced. 83888c7

kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
@h-ohta
fix: roboteq stamped (tier4#156)
0f773a9
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
Fix initialpose topic check (#154) (#156)
be46f09
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
@h-ohta
feat(obstacle_stop_planner): add parameter for voxel_grid (#156)
04e14ad 
* feat(obstacle_stop_planner): add parameter for voxel grid

* fix: parameter
This was referenced Jan 21, 2023
Merged
Merged
Merged
Merged
takayuki5168 added a commit that referenced this pull request Mar 13, 2023
@0x126 @takayuki5168
feat(planning_launch): tune obstacle avoidance (#156) (#169)
654871c 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KeisukeShima KeisukeShima KeisukeShima approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@kenji-miyake kenji-miyake kenji-miyake approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hayato-m126 @yukkysaito @kenji-miyake @KeisukeShima