Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Move segmentation container to preprocessor container #141

Closed
wants to merge 1 commit into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 29, 2021

PR Type

  • Improvement

Related Links

Description

Separation of pointcloud process container raises total cpu usage by 5-10 %, so I move obstacle segmentation container to pointcloud preprocess container.
See the outputs of mpstat below
before
after

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@yukkysaito
Copy link
Collaborator

議論点

  • perceptionを/sensing/lidar/pointcloud_preprocessor/pointcloud_preprocessor_containerというコンテナで動かすのに違和感
  • モジュール間でまたぐのであれば、ground segmentationだけじゃなく、CenterPoint, Clustering, Localization用のvoxel grid filterもコンテナとしてまとめるべき

@yukkysaito
Copy link
Collaborator

@wep21 ちょっと今晩のTL syncで話し合うので待ってもらいたいのですが、一案としては
autoware_launcher.launchにpointcloud_containerという変数を定義してもらってsensing, perception, localizationでコンテナ名を共有できるようにしてもらう感じになるかなと思います。
コンテナ名候補

  • /common/pointcloud_container
  • /pointcloud_container
  • /sensing/lidar/pointcloud_container

@wep21 wep21 marked this pull request as draft November 29, 2021 08:24
@wep21 wep21 closed this Dec 9, 2021
@wep21 wep21 deleted the move-container branch December 9, 2021 06:57
j4tfwm6z pushed a commit that referenced this pull request Feb 1, 2022
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants