Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): aeb update for v0.3.19 #1558

Open
wants to merge 8 commits into
base: beta/v0.3.19
Choose a base branch
from

Conversation

danielsanchezaran
Copy link

@danielsanchezaran danielsanchezaran commented Sep 27, 2024

Description

This PR updates the AEB module to be closer to current autoware's AEB and adds polling subscribers (AEB depends on them) to let the AEB module subscribe to its target topics.

Requires updates to launch: https://github.com/tier4/autoware_launch.x1.eve/pull/492

Related links

Parent Issue:

How was this PR tested?

Using the Driving Log Replayer (DLR) to confirm proper functioning:

Screencast.from.09-27-2024.11.12.33.AM.webm

The updated AEB module itself has been tested with different branches with the DLR: https://docs.google.com/spreadsheets/d/110Cbkh-LGIVjvAY4dPW4HzMc881dS1sRs-lmIjScH5k/edit?gid=1605864141#gid=1605864141

Real life tests have also been conducted by X1/Eve team (using a different branch as base)

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…autowarefoundation#8569)

* make it so AEB works with only one req path type (imu or MPC)

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix missing mpc path return

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add check

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* modify no path msg

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Copy link

sonarcloud bot commented Sep 27, 2024

@danielsanchezaran danielsanchezaran changed the title feat/aeb update for v0.3.19 feat(autonomous_emergency_braking): aeb update for v0.3.19 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants