Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

rename topic name twist -> odometry #568

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

takayuki5168
Copy link
Contributor

Description

rename twist to odometry

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@takayuki5168
Copy link
Contributor Author

This relates to this launcher update
tier4/autoware_launch-old#109

I'll look into more when trying planning_simulator lator, so it's merge ready for this PR now

@taikitanaka3
Copy link
Contributor

@takayuki5168
is there any other packages that still rcieves /localization/twist ?

@takayuki5168
Copy link
Contributor Author

@taikitanaka3 In P/C packages, this is all.

@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Nov 10, 2021

@takayuki5168
for control packages can you modify obstacle collision checker and lane departure checker as well?

@takayuki5168
Copy link
Contributor Author

Ah sorry, this is only planning packages. I'll change control packages as well.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Nov 10, 2021

It seems in control, there are no packages that uses /localization/twist?
Anyway most of the control packages are under porting, so I will look into this translation in control packages later.
Is it ok? If so, I think it's merge ready
@taikitanaka3

@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Nov 10, 2021

@takayuki5168
All right
TODO modify control package to localizatin/kinematic_state in Another PR

@taikitanaka3 taikitanaka3 merged commit fb25997 into use-autoware-auto-msgs Nov 10, 2021
@taikitanaka3 taikitanaka3 deleted the auto/odometry-msg branch November 10, 2021 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants